Make validation optionally caller-handled for IniParse #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zakird
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had an issue with ZGrab2 when using both CLI args and an ini file for the
Multiplemodule. The desired behavior is that Validation logic for ZCommander is applied after parsing both the ini file AND the CLI args. This is because it's often the case that the ini file alone might fail validation as the user has passed in some args thru CLI args.This PR allows callers to optionally specify that they will handle calling
Validateon the IniParser, making it their responsibility. This allows them to parse both the ini file and the CLI args before checking if everything is valid.