Show update release URL for installed version#702
Draft
TheJulianJES wants to merge 3 commits intozigpy:devfrom
Draft
Show update release URL for installed version#702TheJulianJES wants to merge 3 commits intozigpy:devfrom
TheJulianJES wants to merge 3 commits intozigpy:devfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #702 +/- ##
=======================================
Coverage 97.51% 97.51%
=======================================
Files 62 62
Lines 10946 10947 +1
=======================================
+ Hits 10674 10675 +1
Misses 272 272 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This changes ZHA update entities to show the
release_urlof the latest firmware (provided as.downgrades[0]).Additional information
For zigpy-ota provided updates, the
release_urlis generally a link to the pull request where that update was submitted. The pull request also shows more context for the update, potentially with additional release notes in the comments. This also allows us to have an easy place to collect feedback for these updates and for HA users to find that, even after they already installed the update.We can also consider showing the latest (markdown) release notes if that update is already installed. If so, should only the latest version's release notes be shown, the last 5, or all of them?
Related:
Newer version installed than latest in OTA repo?
Right now, we'll show the release URL for the latest version in zigpy-ota. If a user has newer firmware installed than in the zigpy-ota repo, should we not show that link then?
This sometimes happens when manufacturers install new firmware in the factory but consider it to be unimportant to upgrade existing devices with.
Apps
ESPHome / HA apps do not use HA's
release_urlbut instead provide the "release announcement link" in the release notes themselves. This may also be useful for us, since we combine multiple upgrade release notes with the PR linked above, but only ever show the link for the latest release.It's also a little easier to spot there IMO, as it's currently a bit hidden at the top. The general update note is only shown below, which Matter might do the other way around even(?)