updated systemctl to have sudo in front to match

[evanowen]

Updated code to have systemctl have sudo in front. Was breaking on my hosts without it (ubuntu 16.04.5 LTS)

Now matches other lines too...
Line 340: sudo -S service
Line 349: sudo -S service

[StevePC]

Have you verified this won't cause a regression? there was work done in the past to remove sudo from as many commands as possible where it wasn't required...

[evanowen]

To answer your question no. If someone somehow got systemctl running as a different user other than root without using sudo this might break their stuff.

However, I am not really sure off the top of my head if that's even possible to get this running without sudo or without making something really insecure. In our org we are using FreeIPA for auth and are using a zenmonitor user. Zenoss then goes into the system and runs the commands as sudo that we specified to gather all the system info. I feel like that's a pretty standard norm to not give a service account full reign over systemctl.

It looks like on like 340, and 349 you guys do pretty much the same thing with the service command as I am describing.

[K0HAX]

Is there a way to create a Configuration Property to toggle this on or off, with the default being off?