This repository was archived by the owner on May 16, 2018. It is now read-only.
Unused region argument from S3 constructor#663
Open
sshilko wants to merge 1 commit intozendframework:masterfrom
Open
Unused region argument from S3 constructor#663sshilko wants to merge 1 commit intozendframework:masterfrom
sshilko wants to merge 1 commit intozendframework:masterfrom
Conversation
Member
Author
|
i'm on it, but sick atm. will take few days. |
Author
|
just sent out the CLA to cla@zend.com |
Member
|
@weierophinney |
Author
|
i did sent an scanned signed CLA as required in good resolution and etc @weierophinney |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$region argument is never used and is confusing
https://github.com/zendframework/zf1/blob/master/library/Zend/Service/Amazon/Abstract.php#L81