This repository was archived by the owner on May 16, 2018. It is now read-only.
Pass raw headers from imap storage as "raw" when creating a message#605
Open
jaspernbrouwer wants to merge 1 commit intozendframework:masterfrom
Open
Pass raw headers from imap storage as "raw" when creating a message#605jaspernbrouwer wants to merge 1 commit intozendframework:masterfrom
jaspernbrouwer wants to merge 1 commit intozendframework:masterfrom
Conversation
Member
|
ping @weierophinney |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the changes related to ZF2015-04, some messages that are read from imap throw an "Invalid header value detected" exception.
Zend_Mail_Storage_Imap::getMessage()instantiates a newZend_Mail_Messagewith an array of parameters. When these parameters contain the keyraw, all occurrences of\nnot preceded with\rare replaced with\r\nin its value.Next
Zend_Mail_Partwill useZend_Mime_Decode::splitMessageto turn the string into an array of headers, which is later validated.But:
Zend_Mail_Storage_Imap::getMessage()doesn't use the keyraw, but usesheadersin stead. In this case the replace of\nto\r\ndoesn't happen. The result is that headers like these will throw the "Invalid header value detected" exception:The
\nwill be seen as invalid.Fix:
This PR fixes this issue by using
rawin stead ofheaders.