GraphQl: Use 'allAttrib' instead of 'attrib'#322
Open
Conversation
Contributor
|
I get this: And before: The desktop tools on quick run seem to be fine. |
Member
Author
|
Looks like it works as expected. We can't filter out which attributes are received, so using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
GraphQl queries use
allAttribfield instead ofattrib.Additional review information
It is planned to get rid of
attribfields server side, to be able to do that we have to stop using it.This is not 1:1 parity with previous output where it was possible to receive only limited amount of attributes from server whereas now it always returns all attribute values on an entity.
This change affects all entity types that have attributes (which are probably all of them).
Testing notes:
Project can use REST or GraphQl based on what fields are requested, but all other entities do use GraphQl to get entities using GraphQl unless explicit rest methods are used (e.g.
get_rest_folder).Resolves #321