Skip to content

Upload: Fix headers handling #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iLLiCiTiT merged 2 commits into from
Apr 1, 2026
Merged

Upload: Fix headers handling #316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3b5877
fix handling of headers kwarg
iLLiCiTiT Apr 1, 2026
b8b5fad
remove headers kwarg from upload reviewable
iLLiCiTiT Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions ayon_api/_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1276,7 +1276,6 @@ def upload_reviewable(
content_type: Optional[str] = None,
filename: Optional[str] = None,
progress: Optional[TransferProgress] = None,
headers: Optional[dict[str, Any]] = None,
**kwargs,
) -> requests.Response:
"""Upload reviewable file to server.
Expand All @@ -1291,7 +1290,6 @@ def upload_reviewable(
filename (Optional[str]): User as original filename. Filename from
'filepath' is used when not filled.
progress (Optional[TransferProgress]): Progress.
headers (Optional[dict[str, Any]]): Headers.

Returns:
requests.Response: Server response.
Expand All @@ -1306,7 +1304,6 @@ def upload_reviewable(
content_type=content_type,
filename=filename,
progress=progress,
headers=headers,
**kwargs,
)

Expand Down
8 changes: 4 additions & 4 deletions ayon_api/server_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1792,7 +1792,10 @@ def _upload_file(
url = self._endpoint_to_url(endpoint, use_rest=False)
progress.set_destination_url(url)

headers = kwargs.setdefault("headers", {})
headers = kwargs.get("headers")
if headers is None:
kwargs["headers"] = headers = {}

headers_keys_by_low_key = {key.lower(): key for key in headers}
if self._session is None:
for key, value in self.get_headers().items():
Expand Down Expand Up @@ -1982,7 +1985,6 @@ def upload_reviewable(
content_type: Optional[str] = None,
filename: Optional[str] = None,
progress: Optional[TransferProgress] = None,
headers: Optional[dict[str, Any]] = None,
**kwargs
) -> requests.Response:
"""Upload reviewable file to server.
Expand All @@ -1997,7 +1999,6 @@ def upload_reviewable(
filename (Optional[str]): User as original filename. Filename from
'filepath' is used when not filled.
progress (Optional[TransferProgress]): Progress.
headers (Optional[dict[str, Any]]): Headers.

Returns:
requests.Response: Server response.
Expand Down Expand Up @@ -2026,7 +2027,6 @@ def upload_reviewable(
progress=progress,
content_type=content_type,
filename=filename,
headers=headers,
request_type=RequestTypes.post,
**kwargs
)
Expand Down
Loading