Merge release_v2.3.34 with hotfixes#664
Merged
Merged
Conversation
Fixed StoragePool mapping for CreateTable
Backport: added method to customize x-build-info
Small test on Compression enum changes
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #664 +/- ##
============================================
+ Coverage 71.44% 71.56% +0.12%
- Complexity 3404 3413 +9
============================================
Files 385 385
Lines 16064 16064
Branches 1684 1686 +2
============================================
+ Hits 11477 11497 +20
+ Misses 3930 3911 -19
+ Partials 657 656 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pnv1
previously approved these changes
Jun 11, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR merges the release_v2.3.34 hotfixes, primarily addressing CreateTable column-family mapping (compression + storage pool) and adding regression tests to ensure tables can be described and re-created from their description without losing column-family settings.
Changes:
- Table: Fix CreateTable column-family mapping to handle nullable compression/storage pool fields and to include the
defaultfamily in requests. - Tests: Add an integration test that creates a table, describes it, and re-creates a copy from the described
TableDescription, validating column-family compression mapping. - Docs/cleanup: Update
CHANGELOG.mdfor 2.3.34 and remove stale commented/blank lines in tests.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| table/src/main/java/tech/ydb/table/impl/BaseSession.java | Fix column-family protobuf mapping (compression/storage pool) and always include all families when creating tables. |
| table/src/test/java/tech/ydb/table/integration/DescribeTableTest.java | Add regression coverage for table copy via describeTable and column-family compression behavior. |
| table/src/test/java/tech/ydb/table/impl/BaseSessionTest.java | Add a unit-level guard intended to lock enum constants for compression mapping (currently needs a small fix to execute). |
| table/src/test/java/tech/ydb/table/impl/pool/FutureHelper.java | Remove stray trailing whitespace-only lines. |
| query/src/test/java/tech/ydb/query/impl/QueryIntegrationTest.java | Remove a commented-out assertion fragment. |
| CHANGELOG.md | Add 2.3.34 release notes describing the hotfixes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pnv1
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.