Skip to content

Merge release_v2.3.34 with hotfixes#664

Merged
alex268 merged 12 commits into
ydb-platform:masterfrom
alex268:master
Jun 11, 2026
Merged

Merge release_v2.3.34 with hotfixes#664
alex268 merged 12 commits into
ydb-platform:masterfrom
alex268:master

Conversation

@alex268

@alex268 alex268 commented Jun 10, 2026

Copy link
Copy Markdown
Member

No description provided.

@alex268 alex268 requested a review from pnv1 June 10, 2026 16:13
@codecov-commenter

codecov-commenter commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.56%. Comparing base (3797fc2) to head (179b1d1).

Files with missing lines Patch % Lines
...src/main/java/tech/ydb/table/impl/BaseSession.java 76.92% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #664      +/-   ##
============================================
+ Coverage     71.44%   71.56%   +0.12%     
- Complexity     3404     3413       +9     
============================================
  Files           385      385              
  Lines         16064    16064              
  Branches       1684     1686       +2     
============================================
+ Hits          11477    11497      +20     
+ Misses         3930     3911      -19     
+ Partials        657      656       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pnv1 pnv1 requested a review from Copilot June 11, 2026 09:02
pnv1
pnv1 previously approved these changes Jun 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR merges the release_v2.3.34 hotfixes, primarily addressing CreateTable column-family mapping (compression + storage pool) and adding regression tests to ensure tables can be described and re-created from their description without losing column-family settings.

Changes:

  • Table: Fix CreateTable column-family mapping to handle nullable compression/storage pool fields and to include the default family in requests.
  • Tests: Add an integration test that creates a table, describes it, and re-creates a copy from the described TableDescription, validating column-family compression mapping.
  • Docs/cleanup: Update CHANGELOG.md for 2.3.34 and remove stale commented/blank lines in tests.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
table/src/main/java/tech/ydb/table/impl/BaseSession.java Fix column-family protobuf mapping (compression/storage pool) and always include all families when creating tables.
table/src/test/java/tech/ydb/table/integration/DescribeTableTest.java Add regression coverage for table copy via describeTable and column-family compression behavior.
table/src/test/java/tech/ydb/table/impl/BaseSessionTest.java Add a unit-level guard intended to lock enum constants for compression mapping (currently needs a small fix to execute).
table/src/test/java/tech/ydb/table/impl/pool/FutureHelper.java Remove stray trailing whitespace-only lines.
query/src/test/java/tech/ydb/query/impl/QueryIntegrationTest.java Remove a commented-out assertion fragment.
CHANGELOG.md Add 2.3.34 release notes describing the hotfixes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread table/src/test/java/tech/ydb/table/impl/BaseSessionTest.java
Comment thread table/src/main/java/tech/ydb/table/impl/BaseSession.java Outdated
@alex268 alex268 merged commit 761966c into ydb-platform:master Jun 11, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants