feat: add safe portal plugin routes - #293
Draft
TrueKrishna wants to merge 3 commits into
Draft
Conversation
Author
|
Production deployment surfaced newly published advisories in the mandatory core-image Verification: clean root |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
portalRoutesdeployment contract for session and signed-upstream pluginsSecurity boundary
PORTAL_PLUGIN_ROUTESis deployment-managed and cannot be overriddenVerification
npm --prefix cli testnpm --prefix cli run typechecknpm --prefix cli run buildnpm --prefix plugins/portal test(108 passed)npm --prefix plugins/portal run typecheckNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.