Skip to content

BUG: map_chunk wrong results when input is empty data#727

Open
ChengjieLi28 wants to merge 12 commits into
xorbitsai:mainfrom
ChengjieLi28:bug/map_chunk_empty_df
Open

BUG: map_chunk wrong results when input is empty data#727
ChengjieLi28 wants to merge 12 commits into
xorbitsai:mainfrom
ChengjieLi28:bug/map_chunk_empty_df

Conversation

@ChengjieLi28

Copy link
Copy Markdown
Contributor

What do these changes do?

Related issue number

Fixes #723

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the bug Something isn't working label Sep 28, 2023
@XprobeBot XprobeBot added this to the v0.7.0 milestone Sep 28, 2023
@codecov

codecov Bot commented Sep 28, 2023

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.64%. Comparing base (b320ca3) to head (9cb4f26).
⚠️ Report is 63 commits behind head on main.

Files with missing lines Patch % Lines
python/xorbits/_mars/dataframe/base/map_chunk.py 0.00% 3 Missing ⚠️

❌ Your project check has failed because the head coverage (49.64%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (b320ca3) and HEAD (9cb4f26). Click for more details.

HEAD has 20 uploads less than BASE
Flag BASE (b320ca3) HEAD (9cb4f26)
unittests 22 2
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #727       +/-   ##
===========================================
- Coverage   82.55%   49.64%   -32.91%     
===========================================
  Files        1058     1058               
  Lines       79780    79775        -5     
  Branches    16504    12431     -4073     
===========================================
- Hits        65861    39604    -26257     
- Misses      11645    38581    +26936     
+ Partials     2274     1590      -684     
Flag Coverage Δ
unittests 49.63% <0.00%> (-32.79%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@XprobeBot XprobeBot modified the milestones: v0.7.0, v0.7.1 Oct 23, 2023
@XprobeBot XprobeBot modified the milestones: v0.7.1, v0.7.2 Nov 21, 2023
@XprobeBot XprobeBot modified the milestones: v0.7.2, v0.7.3 Jan 5, 2024
@XprobeBot XprobeBot modified the milestones: v0.7.3, v0.7.4 Aug 22, 2024
@luweizheng luweizheng removed this from the v0.7.4 milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: df.map_chunk with empty DataFrame cannot work

3 participants