Skip to content

Add view button for password field in add user form#1107

Merged
lashinijay merged 1 commit into
wso2:mainfrom
lashinijay:view-password
Jun 18, 2026
Merged

Add view button for password field in add user form#1107
lashinijay merged 1 commit into
wso2:mainfrom
lashinijay:view-password

Conversation

@lashinijay

@lashinijay lashinijay commented Jun 18, 2026

Copy link
Copy Markdown
Contributor
  • New Features
    • Enhanced password input fields in user management pages with improved component functionality.
Screenshot 2026-06-18 at 13 58 34
  • Configuration
    • RBAC setting can now be configured via environment variables, with default behavior unchanged.

@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@lashinijay, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 41 minutes and 42 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cb0c12d3-7948-441e-8611-6a905e7afb58

📥 Commits

Reviewing files that changed from the base of the PR and between 8fe53c1 and 9a1d3d5.

📒 Files selected for processing (4)
  • console/workspaces/libs/views/src/component/FormElements/TextInput.tsx
  • console/workspaces/pages/identities/src/UserAddPage.tsx
  • console/workspaces/pages/identities/src/UserCreatePage.tsx
  • deployments/docker-compose.yml
📝 Walkthrough

Walkthrough

PasswordInput is re-exported from the FormElements barrel file and then adopted in UserAddPage and UserCreatePage, replacing direct TextField type="password" usage while preserving all form state and validation wiring. Separately, RBAC_ENABLED in docker-compose.yml is changed from a hardcoded true to ${RBAC_ENABLED:-true} for both services.

Changes

PasswordInput Component Adoption

Layer / File(s) Summary
PasswordInput barrel export
console/workspaces/libs/views/src/component/FormElements/index.ts
Adds export * from './PasswordInput' to expose the component through the FormElements barrel.
PasswordInput adoption in UserAddPage and UserCreatePage
console/workspaces/pages/identities/src/UserAddPage.tsx, console/workspaces/pages/identities/src/UserCreatePage.tsx
Both pages import PasswordInput from @agent-management-platform/views and replace their TextField type="password" fields with it, keeping the same value, onChange, error, helperText, and autoComplete bindings.

RBAC_ENABLED Environment Override

Layer / File(s) Summary
RBAC_ENABLED variable substitution
deployments/docker-compose.yml
Changes RBAC_ENABLED: true to RBAC_ENABLED: ${RBAC_ENABLED:-true} for both agent-manager-service and agent-manager-console.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • wso2/agent-manager#1097: Modifies UserAddPage form validation and structure, directly overlapping with this PR's password field change in the same page.

Suggested reviewers

  • RAVEENSR

🐇 A barrel now holds the password secure,
No plain TextField shall linger here.
PasswordInput hops into the form,
While RBAC bends to the env-var norm.
Clean fields, clean config — the warren's in order! 🥕

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title mentions adding a view button for password field, but the actual changes show refactoring to use PasswordInput component across multiple pages and updating docker-compose configuration—not just adding a view button. Clarify whether the title should reflect the broader refactoring scope (PasswordInput component adoption and environment variable configuration) or if it accurately captures the primary change from the developer's perspective.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details
{"name":"HttpError","status":500,"request":{"method":"PATCH","url":"https://api.github.com/repos/wso2/agent-manager/issues/comments/4739667070","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/0.0.0-development octokit-core.js/7.0.6 Node.js/24","authorization":"token [REDACTED]","content-type":"application/json; charset=utf-8"},"body":{"body":"<!-- This is an auto-generated comment: summarize by coderabbit.ai -->\n<!-- review_stack_entry_start -->\n\n[![Review Change Stack](https://storage.googleapis.com/coderabbit_public_assets/review-stack-in-coderabbit-ui.svg)](https://app.coderabbit.ai/change-stack/wso2/agent-manager/pull/1107?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack)\n\n<!-- review_stack_entry_end -->\n<!-- This is an auto-generated comment: review in progress by coderabbit.ai -->\n\n> [!NOTE]\n> Currently processing new changes in this PR. This may take a few minutes, please wait...\n> \n> <details>\n> <summary>⚙️ Run configuration</summary>\n> \n> **Configuration used**: Path: .coderabbit.yaml\n> \n> **Review profile**: CHILL\n> \n> **Plan**: Pro\n> \n> **Run ID**: `88eb3c90-3ec7-4981-bebc-f9563aa9cd5f`\n> \n> </details>\n> \n> <details>\n> <summary>📥 Commits</summary>\n> \n> Reviewing files that changed from the base of the PR and between 6b34f4eaebd94ff5817c8962a2879f6147a3b1e7 and 8fe53c1db349f37c32b053978eb97ee8f5f80a34.\n> \n> </details>\n> \n> <details>\n> <summary>📒 Files selected for processing (4)</summary>\n> \n> * `console/workspaces/libs/views/src/component/FormElements/index.ts`\n> * `console/workspaces/pages/identities/src/UserAddPage.tsx`\n> * `console/workspaces/pages/identities/src/UserCreatePage.tsx`\n> * `deployments/docker-compose.yml`\n> \n> </details>\n> \n> ```ascii\n>  _______________________________________________________________________________\n> < Design to test. Start thinking about testing before you write a line of code. >\n>  -------------------------------------------------------------------------------\n>   \\\n>    \\   (\\__/)\n>        (•ㅅ•)\n>        /   づ\n> ```\n\n<!-- end of auto-generated comment: review in progress by coderabbit.ai -->\n\n<!-- finishing_touch_checkbox_start -->\n\n<details>\n<summary>✨ Finishing Touches</summary>\n\n<details>\n<summary>🧪 Generate unit tests (beta)</summary>\n\n- [ ] <!-- {\"checkboxId\": \"f47ac10b-58cc-4372-a567-0e02b2c3d479\", \"radioGroupId\": \"utg-output-choice-group-unknown_comment_id\"} -->   Create PR with unit tests\n\n</details>\n\n</details>\n\n<!-- finishing_touch_checkbox_end -->\n<!-- tips_start -->\n\n---\n\nThanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=wso2/agent-manager&utm_content=1107)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.\n\n<details>\n<summary>❤️ Share</summary>\n\n- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)\n- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)\n- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)\n- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)\n\n</details>\n\n\n<sub>Comment `@coderabbitai help` to get the list of available commands and usage tips.</sub>\n\n<!-- tips_end -->\n<!-- usage_tips_start -->\n\n> [!TIP]\n> <details>\n> <summary>CodeRabbit can use zizmor to find security issues in GitHub Actions workflow files.</summary>\n> \n> Assertive reviews run zizmor with `--pedantic` for stricter GitHub Actions security checks. See the [zizmor documentation](https://docs.zizmor.sh/) for audit details.\n> \n> </details>\n\n<!-- usage_tips_end -->"},"request":{"retryCount":3,"signal":{},"retries":3,"retryAfter":16}}}

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@deployments/docker-compose.yml`:
- Line 43: The RBAC_ENABLED environment variable uses a generic host key that
can be accidentally overridden by any pre-existing shell or CI variables,
potentially disabling authorization checks. Replace the generic
${RBAC_ENABLED:-true} references at lines 43 and 134 with a project-scoped
environment variable (for example, using a prefix like PROJECT_ or
DOCKER_COMPOSE_) that maps to the container's RBAC_ENABLED variable. This
ensures only intentional project-specific overrides affect the RBAC setting and
prevents accidental disablement from unrelated host variables.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 88eb3c90-3ec7-4981-bebc-f9563aa9cd5f

📥 Commits

Reviewing files that changed from the base of the PR and between 6b34f4e and 8fe53c1.

📒 Files selected for processing (4)
  • console/workspaces/libs/views/src/component/FormElements/index.ts
  • console/workspaces/pages/identities/src/UserAddPage.tsx
  • console/workspaces/pages/identities/src/UserCreatePage.tsx
  • deployments/docker-compose.yml

Comment thread deployments/docker-compose.yml
@lashinijay lashinijay merged commit 50fe4b4 into wso2:main Jun 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants