Set OS and compiler constraints - #35
Open
auscompgeek wants to merge 3 commits into
Open
auscompgeek wants to merge 3 commits into
auscompgeek wants to merge 3 commits into
Conversation
Collaborator
|
This seems to make sense to me, but @AustinSchuh is much more familiar with the nitty gritty of toolchains so I'd rather have him approve |
AustinSchuh
approved these changes
Nov 22, 2025
Contributor
|
That's reasonable. I still feel like there isn't a great consensus in the bazel community for the canonical way to select gcc vs clang, but this is as reasonable as any. |
Member
Author
|
Yeah, I figure since both the toolchain and platform definitions are being controlled here, it makes sense to make the constraint that already exists selectable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sets
rules_cc'scompiler_flagto gcc for the cross-compiler platforms, to allow for easilyselecting gcc targets (e.g. to specify compiler flags) downstream.Example usage:
Also add the OS and compiler constraints to the cross-compilers, since that was also simple to do, to doubly-ensure nobody's trying to request contradictory compilers. (Adding the CPU constraint was too much for my 2am brain.)