feat: add GitHub Actions workflow to check pinned CA certificate validity#1112
feat: add GitHub Actions workflow to check pinned CA certificate validity#1112AlexKaravaev wants to merge 2 commits intomainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fc79b7bf5a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| fi | ||
|
|
||
| - name: Notify maintainers via GitHub issue | ||
| if: failure() && steps.cert_check.outputs.expiring_certs != '' |
There was a problem hiding this comment.
Notify on all certificate check failures
The notification step only runs when steps.cert_check.outputs.expiring_certs is non-empty, but the check step exits immediately for invalid or already expired certificates before writing that output. In those cases the workflow fails silently (no issue is created/updated), which defeats the automation for the most urgent certificate problems and leaves maintainers reliant on manually noticing failed runs.
Useful? React with 👍 / 👎.
Motivation
security-utils/certsare valid and rotated before they expire.Description
workflow_dispatchGitHub Actions workflowsecurity-utils-cert-validity.yamlthat runs daily at 03:00 and checks allsecurity-utils/certs/*.pem.opensslto validate certificate format, fail on already expired certs, and flag certs expiring within 60 days usingthreshold_secondsandopenssl -checkend, and exposeexpiring_certsviaGITHUB_OUTPUT.actions/github-script@v7to create or update a GitHub issue (labelsecurity) listing affected certificates.Testing
Codex Task