[RFC] Start splitting TracyCallstack.cpp#1326
Draft
Lectem wants to merge 2 commits intowolfpld:masterfrom
Draft
Conversation
Main objective of starting this refactoring is to have a `SymbolResolver` abstraction with a clean interface, so that we may easily switch between implementations, and also reuse them more easily in tools and server. This should also help support non-pdb symbols on windows (MinGW mostly?) by allowing libbacktrace to be used on Windows more easily. Move ImageCache to TracySymbols.hpp. For now s_imageCache and s_KrnlCache are still owned by TracyCallstack.cpp but will in the end be moved per "resolver".
For now, still include it directly from TracyCallstack.cpp. Caching of modules/drivers has been moved to `PrecacheProcessDriversAndModules` and is now called from `DbgHelpInit`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main objective of starting this refactoring is to have some kind of
SymbolResolverabstraction with a clean interface.This will let us switch between implementations more easily, and also reuse them in tools and server, notably for offline resolution.
This should also help for non-pdb symbols support on Windows (MinGW mostly?) by allowing
libbacktraceto be used as fallback to DbgHelp (I'm not sure I want to do this, but in any case a cleaner abstraction should help).