Open
Conversation
cconlon
requested changes
Feb 19, 2026
padelsbach
force-pushed
the
padelsbach/crl-decode
branch
from
4c2c36f to
6aec9e8
Compare
padelsbach
force-pushed
the
padelsbach/crl-decode
branch
3 times, most recently
from
e25f361 to
5f03e34
Compare
cconlon
requested changes
Feb 23, 2026
src/java/com/wolfssl/WolfSSLCRL.java
Outdated
| } | ||
|
|
||
| crlPtr = X509_CRL_load_buffer(der, | ||
| WolfSSL.SSL_FILETYPE_ASN1); |
Member
There was a problem hiding this comment.
Can you take a pass over this file for lines that wrap too early? Thanks for fixing the ones in the .c files, but seems like we need the same adjustments here in .java.
Also applies to WolfSSLCRLTest.java
padelsbach
force-pushed
the
padelsbach/crl-decode
branch
from
5f03e34 to
64e3750
Compare
padelsbach
force-pushed
the
padelsbach/crl-decode
branch
from
64e3750 to
34f3518
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Java wrappers for CRL decode functionality which already exists in wolfSSL