Skip to content

Conversation

@douzzer
Copy link
Contributor

@douzzer douzzer commented Jan 14, 2026

wolfcrypt/test/test.c: in random_bank_test(), fix position of a misplaced WC_DRBG_BANKREF gate.

wolfssl/wolfcrypt/falcon.h and wolfssl/wolfcrypt/sphincs.h: in falcon_key and sphincs_key, use WC_BITFIELD foo:1, not bool foo, to fix readability-implicit-bool-conversion.

These are the last couple niggles from WC_RNG_BANK_SUPPORT and llvm-22.0.0_pre20260106.

Detected by and tested with wolfssl-multi-test.sh ... liboqs-all-clang-tidy liboqs-hybrid-all-rpk-clang-tidy clang-tidy-fips-140-3-v6-all-smallstack.

SparkiDev
SparkiDev previously approved these changes Jan 14, 2026
@SparkiDev SparkiDev assigned douzzer and unassigned wolfSSL-Bot Jan 14, 2026
…_key and sphincs_key, use WC_BITFIELD foo:1, not bool, to fix readability-implicit-bool-conversion.
…and longname mappings for ASN subject fields.
@douzzer
Copy link
Contributor Author

douzzer commented Jan 15, 2026

retest this please

Found unhandled java.lang.NullPointerException exception:
Cannot invoke method getEnvironment() on null object

@douzzer
Copy link
Contributor Author

douzzer commented Jan 15, 2026

retest this please

Found unhandled java.io.InterruptedIOException exception:

@douzzer
Copy link
Contributor Author

douzzer commented Jan 15, 2026

note hostap checks can't succeed currently:

Run git clone git://w1.fi/hostap.git hostap
Cloning into 'hostap'...
fatal: unable to connect to w1.fi:
w1.fi[0: 212.71.239.96]: errno=Connection refused
Error: Process completed with exit code 128.

@dgarske dgarske merged commit 0f3c769 into wolfSSL:master Jan 15, 2026
500 of 512 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants