Skip to content

settings_um: make per-usermod sections collapsible - #5861

Open
lost-hope wants to merge 1 commit into
wled:mainfrom
lost-hope:usermod_settings_improvement
Open

lost-hope wants to merge 1 commit into
wled:mainfrom
lost-hope:usermod_settings_improvement

Conversation

@lost-hope

@lost-hope lost-hope commented Sep 19, 2026

Copy link
Copy Markdown
Member

The usermod settings page grows one section per configured usermod and has no way to collapse the ones you're not editing, making it long to scroll on setups with many usermods. Turn each section into a native

/ element (default open, so nothing hides on first load) and add Expand all / Collapse all buttons above the list.

Summary by CodeRabbit

  • New Features
    • Usermod configuration sections can now be expanded or collapsed individually.
    • Added controls to expand or collapse all usermod sections at once.
    • Added visual indicators showing each section’s open or closed state.

The usermod settings page grows one section per configured usermod and
has no way to collapse the ones you're not editing, making it long to
scroll on setups with many usermods. Turn each section into a native
<details>/<summary> element (default open, so nothing hides on first
load) and add Expand all / Collapse all buttons above the list.
@coderabbitai

coderabbitai Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: wled/WLED/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: e0a19c85-f832-4d34-98d3-e69d4bb2ccc5

📥 Commits

Reviewing files that changed from the base of the PR and between 5cc959a and 0d98c6f.

📒 Files selected for processing (1)
  • wled00/data/settings_um.htm

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


Walkthrough

Usermod configuration sections now render as expandable panels with custom arrow markers. New controls expand or collapse all usermod panels through setAllUM(open).

Changes

Usermod configuration panels

Layer / File(s) Summary
Expandable panel structure
wled00/data/settings_um.htm
Usermod sections now use initially open <details> panels with <summary> headings. Custom styles control markers, cursors, and arrow rotation.
Panel state controls
wled00/data/settings_um.htm
setAllUM(open) updates every usermod panel. Buttons invoke it to expand or collapse all panels.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Feature

Suggested reviewers: dedehai

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: making per-usermod sections collapsible on the settings page.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@willmmiles

willmmiles commented Sep 19, 2026

Copy link
Copy Markdown
Member

I'd prefer the MM approach of giving each usermod its own settings page. (Implemented in #5742 - 2f7b323 - with backwards compatibility).

I'll split #5742 in to that change (which should be uncontrovercial, I hope) and a separate PR for embedded usermod UI integration discussion.

@lost-hope

lost-hope commented Sep 19, 2026

Copy link
Copy Markdown
Member Author

I like having it at one page, to cross reference between usermods. but that is a niche need
here a picture of my testing setup with a couple of usermods
grafik
and here collapsed:
grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants