[Slider] Fix Android hitSlop by replacing touchArea overlay with responder system#3951
Open
[Slider] Fix Android hitSlop by replacing touchArea overlay with responder system#3951
Conversation
The touchArea view (absoluteFillObject) sat between the track and thumb in z-order, intercepting touches in the thumb's hitSlop zone on Android. Replaced with onStartShouldSetResponder + onResponderRelease on the container, leveraging the responder system's bubbling pattern where the deepest child (thumb) wins for direct touches. Made-with: Cursor
Contributor
✅ PR Description Validation PassedAll required sections are properly filled out:
Your PR is good for review! 🚀 This validation ensures all sections from the PR template are properly filled. |
Contributor
Author
How to reproduceDrop this into import React, {useState} from 'react';
import {Platform} from 'react-native';
import {View, Text, Slider, Switch, Incubator} from 'react-native-ui-lib';
const TAG = `[Slider-${Platform.OS}]`;
export default function PlaygroundScreen() {
const [disabled, setDisabled] = useState(false);
return (
<View flex padding-20>
<Text text60 marginB-20>
Slider Debug ({Platform.OS})
</Text>
<View row centerV marginB-20>
<Text text70 marginR-10>
Disabled
</Text>
<Switch value={disabled} onValueChange={setDisabled}/>
</View>
<Text text70 marginB-10>
Slider
</Text>
<View
style={{width: '100%', height: 60, justifyContent: 'center'}}
onTouchStart={() => console.log(`${TAG} - PARENT onTouchStart`)}
onTouchEnd={() => console.log(`${TAG} - PARENT onTouchEnd`)}
>
<Slider
value={30}
minimumValue={0}
maximumValue={100}
disabled={disabled}
onSeekStart={() => console.log(`${TAG} - Slider - onSeekStart`)}
onSeekEnd={() => console.log(`${TAG} - Slider - onSeekEnd`)}
onValueChange={(v: number) => console.log(`${TAG} - Slider - onValueChange: ${v.toFixed(1)}`)}
/>
</View>
<Text text70 marginT-40 marginB-10>
Incubator.Slider
</Text>
<View
style={{width: '100%', height: 60, justifyContent: 'center'}}
onTouchStart={() => console.log(`${TAG} - PARENT onTouchStart (Incubator)`)}
onTouchEnd={() => console.log(`${TAG} - PARENT onTouchEnd (Incubator)`)}
>
<Incubator.Slider
value={30}
minimumValue={0}
maximumValue={100}
disabled={disabled}
onSeekStart={() => console.log(`${TAG} - Incubator.Slider - onSeekStart`)}
onSeekEnd={() => console.log(`${TAG} - Incubator.Slider - onSeekEnd`)}
onValueChange={(v: number) => console.log(`${TAG} - Incubator.Slider - onValueChange: ${v.toFixed(1)}`)}
/>
</View>
</View>
);
}What to test
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an Android bug where touches near the Slider thumb fail to start a drag.
The touchArea overlay (absoluteFillObject) intercepted touches in the thumb's hitSlop zone before they reached the PanResponder.
Replaced it with the container's Gesture Responder System (
onStartShouldSetResponder + onResponderRelease) — the thumb (deepest child) wins for direct touches, the container handles track taps.hitSlopnow works consistently on both platforms.Changelog
Slider - Fixed Android bug where touches near the thumb failed to start a drag due to
touchAreaoverlay interceptinghitSloptouches.Additional info