Migrate FloatingButton to use new ScreenFooter component internally#3948
Migrate FloatingButton to use new ScreenFooter component internally#3948
Conversation
✅ PR Description Validation PassedAll required sections are properly filled out:
Your PR is good for review! 🚀 This validation ensures all sections from the PR template are properly filled. |
|
few things regarding the migration -
|
|
lidord-wix
left a comment
There was a problem hiding this comment.
I added some comments, overall looks good :)
Please make the changelog (in the PR description) more clear 🙏🏽
Also - I wasn't able to run locally, had some issues with the yarn install.. will try again tomorrow
|
|
||
| return ( | ||
| <ScreenFooter | ||
| visible={visible} |
There was a problem hiding this comment.
visible is undefined by default in the floating button and true in the screen footer, means that in case the user didn't pass anything and expected it to be invisible, now it will be shown
|
|
||
| const TestCase = (props) => { | ||
| return <FloatingButton {...props} testID={TEST_ID}/>; | ||
| return <FloatingButton hoisted={false} {...props} testID={TEST_ID}/>; |
There was a problem hiding this comment.
All the tests are for the hoisted={false} case, let's add some for the default one
| }); | ||
| }); | ||
|
|
||
| describe('bottomMargin', () => { |
There was a problem hiding this comment.
let's bring back all the bottomMargin tests to make sure the users aren't break
There was a problem hiding this comment.
please format all files before merging the PR (cmd + shift + P -> Format Document) make sure you're doing it with Prettier ESlint (cmd + shift + P -> Format Document With)
…figurations. added api.json support
Description
Changelog
floatingButton - changed to use new ScreenFooter component internally. deprecated original component.
Additional info
Ticket 5000