Feat: Enable Radon scripts to run on binary sources#2406
Open
guidiaz wants to merge 19 commits intowitnet:2.0-basefrom
Open
Feat: Enable Radon scripts to run on binary sources#2406guidiaz wants to merge 19 commits intowitnet:2.0-basefrom
guidiaz wants to merge 19 commits intowitnet:2.0-basefrom
Conversation
…/HEAD into a JSON string Instead or parsing http::Response::body into a RadonMap
aesedepece
requested changes
Oct 20, 2023
rad/src/lib.rs
Outdated
| let (parts, mut body) = response.into_parts(); | ||
|
|
||
| let response: RadonTypes; | ||
| match parts.headers.get("accept-ranges") { |
Member
There was a problem hiding this comment.
When you only what to check for presence and not for value, you can do ``cointains_key`.
rad/src/lib.rs
Outdated
| let mut response_bytes = Vec::<u8>::default(); | ||
| match retrieve.kind { | ||
| RADType::HttpHead => { | ||
| // todo: assert http-head responses should never return binary streams |
Contributor
Author
There was a problem hiding this comment.
Created RadonError response containing RadError::BufferIsNotValue struct.
aesedepece
approved these changes
Oct 30, 2023
aesedepece
requested changes
Nov 27, 2023
Member
aesedepece
left a comment
aesedepece
left a comment
There was a problem hiding this comment.
This is good to go, but will need TAPI guards. Let's leave it open for now and merge once 2.0 TAPI guards are implemented on the 2.0 integration branch.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.