Draft
Conversation
aesedepece
reviewed
Aug 10, 2022
Member
aesedepece
left a comment
aesedepece
left a comment
There was a problem hiding this comment.
I'll be happy to help with the rationale part.
Contributor
Author
Yes, please! Or any other part as well. |
guidiaz
reviewed
Aug 19, 2022
|
|
||
| Full support for script inputs and script outputs, this is the intented way to use scripts. | ||
|
|
||
| When validating a `ValueTransferTransaction`, for each input, if that input has a `redeem_script`, do a script validation. Otherwise, if the input does not have a `redeem_script`, do a normal signature validation. Transactions can combine both script inputs and normal inputs. Script validation is described in the "Script execution" section. |
There was a problem hiding this comment.
could it be possible for an input to have a redeem_script but no witness_script ?
Contributor
Author
There was a problem hiding this comment.
Yes, for example if the redeem_script always returns true. But since the witness_script contains the signatures this would make the input spendable by anyone, so it is basically a donation to the miner.
Member
A draft for the motivation section can be found here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not ready
Close #84