Skip to content

WPB-27892: fix: resolve original caller for call-end "called" message #22101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
blackheaven wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WPB-27892: fix: resolve original caller for call-end "called" message #22101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions apps/webapp/src/script/repositories/calling/CallingRepository.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,9 +636,16 @@ export class CallingRepository {

private readonly handleMissedCall = (conversationId: string, timestamp: number, userId: string) => {
const callDuration = 0;
const parsedConversationId = this.parseQualifiedId(conversationId);
// Prefer the original caller captured when the call started ringing
// (call.initiator = AVS SETUP sender) over the `missedh` userId, which
// is the sender of the missed-trigger message and usually not the
// caller. Falls back when no Call exists locally (e.g. the app
// cold-launched straight into a missed call).
const callerId = this.findCall(parsedConversationId)?.initiator ?? this.parseQualifiedId(userId);
this.injectDeactivateEvent(
this.parseQualifiedId(conversationId),
this.parseQualifiedId(userId),
parsedConversationId,
callerId,
callDuration,
REASON.CANCELED,
new Date(timestamp * 1000).toISOString(),
Expand Down
Loading