WPB-27891: fix: resolve original caller for call-end "called" message - #199
Open
blackheaven wants to merge 1 commit into
Open
WPB-27891: fix: resolve original caller for call-end "called" message#199blackheaven wants to merge 1 commit into
blackheaven wants to merge 1 commit into
Conversation
https://wearezeta.atlassian.net/browse/WPB-27891 Call-end surfaces attributed the message to whoever sent the end/missed-trigger message rather than the original caller, because AVS reported the OTR envelope sender of whichever message triggered each callback (incomingh -> SETUP sender = caller, but closeh/ missedh -> end-message sender, usually not the caller). Persist the SETUP/CONF_START envelope sender (the server-authenticated original caller) for the call lifetime and report it on the close/leave/missed callbacks instead of the end-message sender. In the NSE event path, a SETUP-triggered event uses the authenticated envelope sender (which IS the caller); the self-declared src_userid from the decoded econn_message is used only for the CONF_END->CLOSED fallback, where no SETUP was seen and there is no better signal, falling back to the envelope sender when src_userid is absent. Outgoing calls keep the existing self fallback (no SETUP is seen, so self is the caller).
blackheaven
force-pushed
the
gdifolco/fix-original-caller
branch
from
August 7, 2026 15:30
f92caa2 to
0f23b25
Compare
blackheaven
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-27891
Call-end surfaces attributed the message to whoever sent the end/missed-trigger message rather than the original caller, because AVS reported the OTR envelope sender of whichever message triggered each callback (incomingh -> SETUP sender = caller, but closeh/ missedh -> end-message sender, usually not the caller).
Persist the SETUP/CONF_START envelope sender (the server-authenticated original caller) for the call lifetime and report it on the close/leave/missed callbacks instead of the end-message sender.
In the NSE event path, a SETUP-triggered event uses the authenticated envelope sender (which IS the caller); the self-declared src_userid from the decoded econn_message is used only for the CONF_END->CLOSED fallback, where no SETUP was seen and there is no better signal, falling back to the envelope sender when src_userid is absent.
Outgoing calls keep the existing self fallback (no SETUP is seen, so self is the caller).
It's LLM-generated, please, review it carefully.