Skip to content

fix: Disallow \ and " when renaming a file or folder (WPB-22840)#4539

Merged
ohassine merged 7 commits intodevelopfrom
Disallow-and-when-renaming-a-file-or-folder
Jan 27, 2026
Merged

fix: Disallow \ and " when renaming a file or folder (WPB-22840)#4539
ohassine merged 7 commits intodevelopfrom
Disallow-and-when-renaming-a-file-or-folder

Conversation

@ohassine
Copy link
Member

@ohassine ohassine commented Jan 20, 2026

https://wearezeta.atlassian.net/browse/WPB-22840


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Disallow \ and " when renaming a file or folder

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine changed the title fix: Disallow \ and " when renaming a file or folder fix: Disallow \ and " when renaming a file or folder (WPB-22840) Jan 20, 2026
@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.47%. Comparing base (3f3f5ac) to head (f89dbbd).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4539   +/-   ##
========================================
  Coverage    48.47%   48.47%           
========================================
  Files          575      575           
  Lines        19803    19803           
  Branches      3311     3311           
========================================
  Hits          9600     9600           
  Misses        9189     9189           
  Partials      1014     1014           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f3f5ac...f89dbbd. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link

@ohassine ohassine added this pull request to the merge queue Jan 27, 2026
Merged via the queue into develop with commit 94c30f8 Jan 27, 2026
16 of 17 checks passed
@ohassine ohassine deleted the Disallow-and-when-renaming-a-file-or-folder branch January 27, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants