[PLACEHOLDER] wire/stable version - #81
Draft
OtaK wants to merge 56 commits into
Draft
Conversation
|
This PR is so big! Please, split it 😊 |
|
This PR is so big! Please, split it 😊 |
Kyber PQ KEM is still being worked on and has an active draft: https://datatracker.ietf.org/doc/html/draft-cfrg-schwabe-kyber-04. Additionally, the hybrid scheme that combines X25519 and Kyber is also in the drafting phase: https://www.ietf.org/archive/id/draft-tls-westerbaan-xyber768d00-02.html Given this, it makes no sense for us to provide support for Kyber-based KEMs.
|
This PR is so big! Please, split it 😊 |
instant is no longer maintained the recommended alternative is web-time.
|
This PR is so big! Please, split it 😊 |
They're just too big and overflow the stack when they run.
|
This PR is so big! Please, split it 😊 |
|
This PR is so big! Please, split it 😊 |
|
This PR is so big! Please, split it 😊 |
This allows creating a commit from proposals without sending the proposals over the wire first.
Previously, the tree shrink function would be called eagerly after each remove proposal. If the shrink threshold was reached, the blanked out nodes were removed from the diff tree. If there were additional add proposals in a commit that triggered the tree to grow again, this resulted in incorrect state if there were FEWER add proposals than remove proposals. That's because the blanked out nodes removed during shrinking were not re-added during growing. To fix this, we don't shrink/trim the tree eagerly after each remove proposal, but after remove and add proposals have been processed.
This proves that we don't suffer from the bug fixed in openmls/openmls@26eaa4d0e
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.