feat(measurements): remove date restriction to allow multiple entries per day#1214
Open
sg172003 wants to merge 7 commits intowger-project:masterfrom
Open
feat(measurements): remove date restriction to allow multiple entries per day#1214sg172003 wants to merge 7 commits intowger-project:masterfrom
sg172003 wants to merge 7 commits intowger-project:masterfrom
Conversation
Collaborator
|
coverage: 75.479% (-0.05%) from 75.526% — sg172003:feature/measurement-datetime-field into wger-project:master |
Time assertions are commented out for now since the test can fail depending on the currently set timezone. This should be fixed properly in the future though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the
shouldDisableDaterestriction in the measurement entrydate picker that was preventing multiple entries on the same day.
Why?
Part of wger-project/wger#2116 — now that the backend allows multiple
measurement entries per day, the frontend restriction is no longer needed.
Changes
shouldDisableDateprop fromDatePickerinEntryForm.tsxdateToYYYYMMDDimportChecklist