Repository navigation
feat: make site wordmark configurable via site_name - #30
Merged
Merged
Conversation
The "tumblefish" wordmark was hardcoded in page titles and the masthead across five templates. Add a site_name config value (TUMBLE_SITE_NAME), exposed to HTML templates through a siteName helper that closes over config, and replace the hardcoded string. Defaults to "tumblefish" so existing deployments are unchanged, and it stays independent of the RSS site_title so the visible brand and the feed title can differ.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
tumblefishwordmark was hardcoded in page titles and the mastheadacross five templates. This makes it a config value.
site_nameconfig field (TUMBLE_SITE_NAME), default"tumblefish"siteNamehelper that closes over configin
renderer.go— reaches both the sharedheader.htmlpartial and theper-page
<title>s from a single config read, no handler data-structchanges
header.html,index.html,quote_permalink.html,stats.html,link_posted.htmlBehavior
tumblefish, so existingdeployments render exactly as before.
site_title: the visible brand and the feed titlecan differ, preserving the current split (masthead
tumblefishvs RSSfallback
tumble).Verification
gofmtclean,git diff --checkclean,make buildsucceeds, all testpackages pass
tumblefish.stats/ mastheadtumblefish.(unchanged)TUMBLE_SITE_NAME=linkfish→linkfish.stats/ mastheadlinkfish.,RSS channel title unaffected