fix(theme): simplify types rendering#184
Open
moshams272 wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
avivkeller
reviewed
Jul 15, 2026
| }; | ||
|
|
||
| export const someType = model => `{${resolve(model)}}`; | ||
| export const someType = model => (model ? `{${model}}` : 'unknown'); |
Member
There was a problem hiding this comment.
Suggested change
| export const someType = model => (model ? `{${model}}` : 'unknown'); | |
| export const someType = model => `{${model ?? 'unknown' }}`; |
Even if it's unknown, we want that within the brackets
avivkeller
reviewed
Jul 15, 2026
Comment on lines
20
to
21
Member
There was a problem hiding this comment.
These can also be routed to someType now, I think
Member
|
@moshams272 Can you bump |
Contributor
Author
Oh! I use it from github from last time 😅 |
moshams272
force-pushed
the
fix/simplify-types
branch
from
5679d50 to
6925bb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR simplifies types rendering and rely on
nodejs/doc-kit'soxc-parser