Skip to content

fix(theme): prevent empty Type Parameters heading and don't appear in callable interface#183

Merged
avivkeller merged 1 commit into
webpack:mainfrom
moshams272:fix/theme-type-parameters
Jul 15, 2026
Merged

fix(theme): prevent empty Type Parameters heading and don't appear in callable interface#183
avivkeller merged 1 commit into
webpack:mainfrom
moshams272:fix/theme-type-parameters

Conversation

@moshams272

Copy link
Copy Markdown
Contributor

Summary

TypeDoc stores the function arguments of a Callable Interface inside the typeParameters property, that makes no sense as it should under Call Signature heading (if it has multiple signatures) not Type Parameters heading.

This PR solves that and prevent empty Type Parameters heading.

Before:

image image

After:

image image

@vercel

vercel Bot commented Jul 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
webpack-doc-kit Ready Ready Preview, Comment Jul 14, 2026 6:10am

Request Review

@avivkeller

Copy link
Copy Markdown
Member

Would you mind updating our type generator to not waltz around TypeScript and just output an opening bracket ({) followed by the complete TypeScript type, followed by a closing bracket (}), which'll be supported in nodejs/doc-kit#887

@avivkeller

Copy link
Copy Markdown
Member

that should fix all our issues, since we won't need to reconstruct the types with our own emitter, and we can just rely on typedoc (right?)

@avivkeller avivkeller left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the mean time, LGTM. Feel free to do my suggestion here or in a follow-up, thank you!

@moshams272

Copy link
Copy Markdown
Contributor Author

Would you mind updating our type generator to not waltz around TypeScript and just output an opening bracket ({) followed by the complete TypeScript type, followed by a closing bracket (}), which'll be supported in nodejs/doc-kit#887

Awesome, Thanks for your hard work 🤍

I'll open a follow-up to isolate things :)

@avivkeller avivkeller merged commit 76d8030 into webpack:main Jul 15, 2026
10 checks passed
@moshams272 moshams272 deleted the fix/theme-type-parameters branch July 15, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants