feat: add reservation state and expiry time metrics - #164
Open
cjedro wants to merge 2 commits into
Open
Conversation
Member
|
why not just add ProvisioningState as label? might make it more easy to use instead of a "myserious number" |
|
Contributor
Author
i've migrated from one series that has the "myserious number" to multiple metrics that has the state as label and is one if its the current state. I wanted to keep expiry metric and state metric seperate but if you like that more i'm happy to change it again |
Contributor
Author
|
@mblaschke did you already have time to look at my changes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was planning to create Alerts some time before Reservations expire. Seems like the current approach is more focused about usage. I've added two more metrics which reflect the state and the expiry time.
I've tested this already with ghcr.io/cloudeteer/azure-resourcemanager-exporter:cloudeteer-reservations
Please let me know what you think about this approach. As i dont need to collect based off billingAccounts the collector only collects the new metrics when no scopes are defined.