fix: conditional create should also not require user verification#908
Open
joostdebruijn wants to merge 1 commit into
Open
fix: conditional create should also not require user verification#908joostdebruijn wants to merge 1 commit into
joostdebruijn wants to merge 1 commit into
Conversation
Contributor
Author
|
I think I previously read this document, stating that only the UP check should be relaxed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Target branch: 5.3.x
Resolves issue: n/a
In #719 we talked about the support of Conditional Create in this library. It was built in PR #748 and released with v5.3.0.
When I tested the implementation back then with on the development branch, it worked perfectly in Chrome. However, when I was implementing it with the stable version the
CheckUserVerificationvalidator failed. Theuvbit is also set tofalsewhen doing a conditional create. It's stated explicitly in the Chrome docs (now): that both "User Presence" and "User Verified" arefalse. Either I missed something back then, or something has changed between then and the release. Nevertheless, I hereby propose a change to align with this behaviour targetted at the 5.3-branch (I saw the 5.4 branch already quite active, but I think this is a bug fix on 5.3 in the first place).