Fix inactive pane dimming on dark themes and make intensity configurable#11473
Fix inactive pane dimming on dark themes and make intensity configurable#11473Akeuuh wants to merge 3 commits into
Conversation
Inactive panes were dimmed by a fixed 10% foreground overlay, toggled only on/off via `should_dim_inactive_panes`, so users could not make the dimming subtler or stronger. Add an `inactive_pane_dimming_percentage` setting (u8, 0-100, default 10 to preserve current behavior), synced to cloud like the existing toggle and surfaced as a slider under Appearance > Panes that is shown only when dimming is enabled. The pane view applies the chosen opacity through a new `WarpTheme::inactive_pane_overlay_with_opacity` helper and re-renders on `PaneSettingsChangedEvent::InactivePaneDimmingPercentage`.
The inactive-pane dimming overlay blended toward the theme foreground color. On dark themes the foreground is light, so enabling "Dim inactive panes" actually brightened inactive panes rather than dimming them (GH#5401). Fade toward the window background instead, so inactive panes recede on both light and dark themes; the configurable percentage now drives a background-based scrim.
|
This PR is not linked to an issue that is marked with Issue-state enforcement details:
Readiness check:
To continue, link this PR to a same-repo issue such as Powered by Oz |
There was a problem hiding this comment.
This PR is not linked to an issue that is marked with ready-to-implement.
Issue-state enforcement details:
-
Associated same-repo issues checked: #5401
-
Required readiness label:
ready-to-implement
Readiness check:
- #5401: missing
ready-to-implement; readiness labels present: none
To continue, link this PR to a same-repo issue such as Closes #123 in the PR description, and make sure that issue has ready-to-implement.
Powered by Oz
Description
Fixes inactive-pane dimming on dark themes and makes the dimming intensity user-configurable.
Bug fix (GH#5401): the "Dim inactive panes" overlay blended toward the theme foreground color. On dark themes the foreground is light, so dimming actually brightened inactive panes. The overlay now fades toward the window background, so inactive panes recede on both light and dark themes. (
WarpTheme::inactive_pane_overlay_with_opacity; the legacyinactive_pane_overlayused for modal/header scrims is unchanged.)New setting:
appearance.panes.inactive_pane_dimming_percentage(u8,0–100, default10), surfaced as a slider under Settings → Appearance → Panes, shown only when "Dim inactive panes" is enabled. The pane re-renders onPaneSettingsChangedEvent::InactivePaneDimmingPercentage; synced to cloud like the existing toggle.Files:
app/src/settings/pane.rs,app/src/pane_group/pane/view/mod.rs,app/src/settings_view/appearance_page.rs,crates/warp_core/src/ui/theme/color.rs.Linked Issue
Closes #5401
Supersedes #11472 (filed by me, then flagged as a duplicate of #5401 by Oz).
Testing
./script/run(macOS OSS build): on a dark theme, enabling "Dim inactive panes" now darkens the inactive split instead of brightening it; the slider changes intensity live; default (10) is a subtle dim.cargo fmt -- --check✅cargo clippy --workspace --exclude warp_completer --all-targets --tests -- -D warnings✅ (+-p warp_completer✅)cargo test --doc✅nextestfailures were environment-dependent (SSH integration tests needing a backend, and a non-hermetic settings-migration test that reads the real~/.warp/settings.toml), unrelated to this change.Screenshots / Videos
Enregistrement.de.l.ecran.2026-05-21.a.14.40.03.mov
Agent Mode
CHANGELOG-BUG-FIX: "Dim inactive panes" now dims (rather than brightens) inactive panes on dark themes.
CHANGELOG-IMPROVEMENT: Inactive pane dimming intensity is now configurable in Settings → Appearance → Panes.