Skip to content

Fix inactive pane dimming on dark themes and make intensity configurable#11473

Draft
Akeuuh wants to merge 3 commits into
warpdotdev:masterfrom
Akeuuh:axel/configurable-pane-dimming
Draft

Fix inactive pane dimming on dark themes and make intensity configurable#11473
Akeuuh wants to merge 3 commits into
warpdotdev:masterfrom
Akeuuh:axel/configurable-pane-dimming

Conversation

@Akeuuh
Copy link
Copy Markdown
Contributor

@Akeuuh Akeuuh commented May 21, 2026

Description

Fixes inactive-pane dimming on dark themes and makes the dimming intensity user-configurable.

Bug fix (GH#5401): the "Dim inactive panes" overlay blended toward the theme foreground color. On dark themes the foreground is light, so dimming actually brightened inactive panes. The overlay now fades toward the window background, so inactive panes recede on both light and dark themes. (WarpTheme::inactive_pane_overlay_with_opacity; the legacy inactive_pane_overlay used for modal/header scrims is unchanged.)

New setting: appearance.panes.inactive_pane_dimming_percentage (u8, 0–100, default 10), surfaced as a slider under Settings → Appearance → Panes, shown only when "Dim inactive panes" is enabled. The pane re-renders on PaneSettingsChangedEvent::InactivePaneDimmingPercentage; synced to cloud like the existing toggle.

Files: app/src/settings/pane.rs, app/src/pane_group/pane/view/mod.rs, app/src/settings_view/appearance_page.rs, crates/warp_core/src/ui/theme/color.rs.

Linked Issue

Closes #5401

Supersedes #11472 (filed by me, then flagged as a duplicate of #5401 by Oz).

Note: feature/bug request — opening as draft pending a ready-to-spec / ready-to-implement label (and a spec under specs/ if the team wants one) per CONTRIBUTING.md.

Testing

  • Manually tested locally with ./script/run (macOS OSS build): on a dark theme, enabling "Dim inactive panes" now darkens the inactive split instead of brightening it; the slider changes intensity live; default (10) is a subtle dim.
  • cargo fmt -- --check
  • cargo clippy --workspace --exclude warp_completer --all-targets --tests -- -D warnings ✅ (+ -p warp_completer ✅)
  • cargo test --doc
  • Touched-code unit tests pass; the only local nextest failures were environment-dependent (SSH integration tests needing a backend, and a non-hermetic settings-migration test that reads the real ~/.warp/settings.toml), unrelated to this change.

Screenshots / Videos

Enregistrement.de.l.ecran.2026-05-21.a.14.40.03.mov

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-BUG-FIX: "Dim inactive panes" now dims (rather than brightens) inactive panes on dark themes.
CHANGELOG-IMPROVEMENT: Inactive pane dimming intensity is now configurable in Settings → Appearance → Panes.

Inactive panes were dimmed by a fixed 10% foreground overlay, toggled
only on/off via `should_dim_inactive_panes`, so users could not make the
dimming subtler or stronger.

Add an `inactive_pane_dimming_percentage` setting (u8, 0-100, default 10
to preserve current behavior), synced to cloud like the existing toggle
and surfaced as a slider under Appearance > Panes that is shown only when
dimming is enabled. The pane view applies the chosen opacity through a
new `WarpTheme::inactive_pane_overlay_with_opacity` helper and re-renders
on `PaneSettingsChangedEvent::InactivePaneDimmingPercentage`.
@cla-bot cla-bot Bot added the cla-signed label May 21, 2026
@github-actions github-actions Bot added the external-contributor Indicates that a PR has been opened by someone outside the Warp team. label May 21, 2026
The inactive-pane dimming overlay blended toward the theme foreground
color. On dark themes the foreground is light, so enabling "Dim inactive
panes" actually brightened inactive panes rather than dimming them
(GH#5401). Fade toward the window background instead, so inactive panes
recede on both light and dark themes; the configurable percentage now
drives a background-based scrim.
@Akeuuh Akeuuh changed the title Add configurable inactive pane dimming percentage Fix inactive pane dimming on dark themes and make intensity configurable May 21, 2026
@Akeuuh Akeuuh marked this pull request as ready for review May 21, 2026 12:42
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 21, 2026

@Akeuuh

This PR is not linked to an issue that is marked with ready-to-implement.

Issue-state enforcement details:

Readiness check:

To continue, link this PR to a same-repo issue such as Closes #123 in the PR description, and make sure that issue has ready-to-implement.

Powered by Oz

Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Akeuuh

This PR is not linked to an issue that is marked with ready-to-implement.

Issue-state enforcement details:

  • Associated same-repo issues checked: #5401

  • Required readiness label: ready-to-implement

Readiness check:

  • #5401: missing ready-to-implement; readiness labels present: none

To continue, link this PR to a same-repo issue such as Closes #123 in the PR description, and make sure that issue has ready-to-implement.

Powered by Oz

@Akeuuh Akeuuh marked this pull request as draft May 21, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed external-contributor Indicates that a PR has been opened by someone outside the Warp team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add setting to adjust Pane dimming radiance, since "Dim inactive panes" doesn't actually dim in dark themes, it lightens

1 participant