Detect common skill updates during script/run#11455
Open
zachlloyd wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR routes normal ./script/run common-skills setup through the installer --if-needed path so interactive runs can detect and accept upstream common-skill lock updates, and refreshes skills-lock.json to the latest accepted common-skills lock.
Concerns
- No blocking correctness, security, or spec-alignment concerns found in the changed lines.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
./script/runcommon-skills setup through the installer's--if-neededpath instead of exiting early after--verify-only.warpdotdev/common-skillscontent and prompt to refreshskills-lock.json.skills-lock.jsonto the latest accepted common-skills lock produced during verification.Agent conversation: https://staging.warp.dev/conversation/15c99a45-ffd2-4d3c-9d6e-0267b310c115
Linked Issue
Testing
bash -n script/rungit diff --check/Users/zach/Projects/common-skills/scripts/install_common_skills --repo-root /Users/zach/Projects/warp --verify-only --quietcargo fmt --all --check --manifest-path /Users/zach/Projects/warp/Cargo.tomlcargo clippy --workspace --all-targets --all-features --tests -- -D warnings./script/run; it detected updated common skills, refreshed the lock after confirmation, reinstalled, and continued into the app build.Agent Mode
CHANGELOG-NONE
Co-Authored-By: Oz oz-agent@warp.dev