Show the question in AskUserQuestion permission notifications - #86
Open
RomanBOGR wants to merge 1 commit into
Open
Show the question in AskUserQuestion permission notifications#86RomanBOGR wants to merge 1 commit into
RomanBOGR wants to merge 1 commit into
Conversation
The preview in on-permission-request.sh handles .command and .file_path and falls back to tostring[0:80] for everything else. For AskUserQuestion that fallback dumps raw JSON, so the notification truncates before the question itself. Add an elif branch for .questions, plus four tests covering Bash, Write, AskUserQuestion and the unknown-tool fallback. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The preview in
on-permission-request.shis built from.commandor.file_path, and everything else falls back totostring[0:80]. ForAskUserQuestionthat fallback dumps raw JSON, so the notification readsand gets truncated before the question itself.
This matters most when several Claude Code sessions run in parallel: the notification is the only thing visible from another tab, and a decision prompt is exactly the case where you want to know what is being asked before switching to it.
Adds one
elif .questionsbranch, plus four tests coveringBash,Write,AskUserQuestionand the unknown-tool fallback — the preview expression had no coverage before.tests/test-hooks.sh: 61 passed, 0 failed.🤖 Generated with Claude Code