Add logging adapter for storage#39
Open
wagnerdevocelot wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a logging adapter around the existing in-memory store to record metrics and log all storage operations.
- Wraps the in-memory store in a
LoggingAdapterand updatesmain.goto use it - Implements
LoggingAdapterwith per-operation logging and counters - Exposes a
Metrics()method to retrieve collected operation counts
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| main.go | Updated store initialization to use LoggingAdapter |
| logging_adapter.go | Introduced LoggingAdapter that delegates to storage and logs each call |
Comments suppressed due to low confidence (3)
logging_adapter.go:51
- [nitpick] Rename the local variable
copyto avoid shadowing the built-incopyfunction and improve clarity, e.g.,metricsCopy.
copy := make(map[string]int, len(l.metrics))
logging_adapter.go:37
- Add unit tests to verify that
LoggingAdaptercorrectly delegates to the underlying storage and accurately records metrics for each operation.
func NewLoggingAdapter(backend fullStorage) *LoggingAdapter {
main.go:17
- [nitpick] Include documentation or examples on how to access and expose the collected metrics (e.g., via an HTTP endpoint or monitoring system) so users can make use of the new metrics feature.
// This demonstrates how a new storage adapter can be integrated gradually.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LoggingAdaptermain.gofor gradual replacementTesting
go test ./...https://chatgpt.com/codex/tasks/task_e_6874413d30d08328b231ade06e0f5eda