fix(runtime-core): allow an empty dynamic component (fix #3632) - #15556
JonathanYin wants to merge 1 commit into
Conversation
resolveDynamicComponent treated an empty string as a component name, so it resolved to itself and createVNode warned about an invalid type. It already renders a comment, matching an explicit null.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthrough
ChangesDynamic component resolution
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to Empty dynamic components now render as comments without the prior invalid-type behavior; no actionable merge risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
closes #3632
<component :is="''">warned about an invalid type, though it alreadyrenders nothing, the same as
:is="null".Summary by CodeRabbit