-
Notifications
You must be signed in to change notification settings - Fork 77
Add HarmonyOS example #382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Wow, are all those supporting files required for every harmony application? FYI, vsg::Logger can be sub-classed to enable all vsg::info/vsg::warn etc. messages to be redirected to a custom logger. See vsglogger example. I think this would be better than having a macro as it would work for all VSG messages. |
- Removed obsolete test files and mock configuration files
|
Many files are included with the template project; I have removed some unnecessary files. I have also added a Harmony implementation of vsg::Logger. |
|
Thanks for the changes. Would it be worth moving the HarmonyLogger into the VSG alongside the other Harmony platform files? |
|
I don't think it's necessary to include it in VSG, as it's just an application-layer example. VSG users should refine it according to their own needs. |
| "name": "default", | ||
| "type": "HarmonyOS", | ||
| "material": { | ||
| "certpath": "C:\\Users\\huang\\.ohos\\config\\default_VsgHarmony_Gj_LbL9cJ7EqTcCncNlPZOjKrVWG1MP7KjQ_Hw-o5vI=.cer", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't feel right to have user specific config files. Will these be overwritten by the dev environment at compile time or at runtime?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, this is the signature automatically created by the IDE for the debug version. It's associated with the Huawei developer account and should be deleted. When others debug on a real device, the IDE will guide them to create a new signature.
Removed signingConfigs section from build-profile.json5.
Since the emulator included with DevEco Studio does not support Vulkan, this demo can only run on a real device.
