Skip to content

Make scan concurrency concurrent again? #6613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AdamGS wants to merge 2 commits into from
Closed

Make scan concurrency concurrent again? #6613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
265e906
Make scan concurrency concurrency again?
AdamGS Feb 20, 2026
b06c3ac
Try this one
AdamGS Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions vortex-datafusion/src/persistent/opener.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,9 +352,7 @@ impl FileOpener for VortexOpener {
scan_builder = scan_builder.with_limit(limit);
}

if let Some(concurrency) = scan_concurrency {
scan_builder = scan_builder.with_concurrency(concurrency);
}
scan_builder = scan_builder.with_concurrency(scan_concurrency.unwrap_or(4));

let stream = scan_builder
.with_metrics_registry(metrics_registry)
Expand Down
8 changes: 4 additions & 4 deletions vortex-scan/src/scan_builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,10 +349,10 @@ impl<A: 'static + Send> Stream for LazyScanStream<A> {
LazyScanState::Builder(builder) => {
let builder = builder.take().vortex_expect("polled after completion");
let ordered = builder.ordered;
let num_workers = std::thread::available_parallelism()
.map(|n| n.get())
.unwrap_or(1);
let concurrency = builder.concurrency * num_workers;
// let num_workers = std::thread::available_parallelism()
// .map(|n| n.get())
// .unwrap_or(1);
let concurrency = builder.concurrency;
let handle = builder.session.handle();
let task = handle.spawn_blocking(move || {
builder.prepare().and_then(|scan| scan.execute(None))
Expand Down
Loading