Merged
Conversation
Merging this PR will not alter performance
Comparing 
Footnotes
|
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs
force-pushed
the
ji/compute-cleanup-compare
branch
from
e0103ab to
9c4d630
Compare
…-compare # Conflicts: # encodings/datetime-parts/src/compute/compare.rs # encodings/fastlanes/benches/compute_between.rs # vortex-array/src/compute/conformance/consistency.rs # vortex-array/src/expr/exprs/between/mod.rs # vortex-array/src/expr/exprs/binary/mod.rs # vortex-array/src/expr/exprs/operators.rs
…-compare # Conflicts: # encodings/alp/src/alp/compute/compare.rs # encodings/bytebool/src/compute.rs # encodings/datetime-parts/src/compute/compare.rs # encodings/decimal-byte-parts/src/decimal_byte_parts/compute/compare.rs # encodings/fastlanes/benches/compute_between.rs # encodings/fastlanes/src/for/compute/compare.rs # encodings/fsst/benches/fsst_compress.rs # encodings/fsst/src/compute/compare.rs # encodings/sequence/src/compute/compare.rs # encodings/sparse/src/lib.rs # fuzz/fuzz_targets/file_io.rs # fuzz/src/array/compare.rs # fuzz/src/array/mod.rs # vortex-array/src/arrays/dict/compute/mod.rs # vortex-array/src/arrays/varbin/compute/compare.rs # vortex-array/src/compute/conformance/consistency.rs # vortex-array/src/expr/exprs/binary/mod.rs # vortex-array/src/expr/exprs/dynamic.rs # vortex-array/src/expr/exprs/list_contains/mod.rs # vortex-python/src/arrays/mod.rs
robert3005
approved these changes
Feb 20, 2026
Contributor
robert3005
left a comment
robert3005
left a comment
There was a problem hiding this comment.
you have a comment in between that you want to return lazy compare and now you can
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the lazy compute migration. We add a ArrayBuiltIn
a.binary(b, Op)method to create a lazily evaluated array tree.We remove RSub and RDiv since we don't need to swap args any more. Since we have
execute_parent.Note to review: Start looking at
vortex-array/{compute,exprs}.compute method have move to exprs
use
a.binary(b, Op)from ArrayBuiltIn over compare and other compute methods