Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/core/notebook.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,8 @@ Notebook::Notebook(const std::string &local_data_folder, const std::string &root
NotebookType type)
: local_data_folder_(local_data_folder), root_folder_(root_folder), type_(type) {}

Notebook::~Notebook() = default;

void Notebook::EnsureId() {
if (config_.id.empty()) {
config_.id = GenerateUUID();
Expand Down
2 changes: 1 addition & 1 deletion src/core/notebook.h
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ struct NotebookRecord {

class Notebook {
public:
virtual ~Notebook() = default;
virtual ~Notebook();

const std::string &GetId() const { return config_.id; }
const std::string &GetRootFolder() const { return root_folder_; }
Expand Down
1 change: 0 additions & 1 deletion src/platform/process_utils.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ FILE *ProcessUtils::OpenPipe(const std::string &command, const char *mode) {
#ifdef _WIN32
return _popen(command.c_str(), mode);
#else
(void)utf8_mode;
return popen(command.c_str(), mode);
#endif
}
Expand Down