Skip to content

feat: use vlt registry for vlt CLI benchmarks #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vltbaudbot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: use vlt registry for vlt CLI benchmarks #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/benchmark.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ jobs:
- name: Run Benchmarks variations
env:
CODEARTIFACT_AUTH_TOKEN: ${{ steps.aws.outputs.token }}
VLT_REGISTRY_URL: ${{ secrets.VLT_REGISTRY_URL }}
VLT_REGISTRY_AUTH_TOKEN: ${{ secrets.VLT_REGISTRY_AUTH_TOKEN }}
GH_REGISTRY: ${{ secrets.GH_REGISTRY }}
GH_AUTH_TOKEN: ${{ secrets.GH_AUTH_TOKEN }}
Expand Down
11 changes: 10 additions & 1 deletion scripts/variations/common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,16 @@ BENCH_INSTALL_BERRY="corepack yarn@latest install"
BENCH_INSTALL_ZPM="yarn install --silent"
BENCH_INSTALL_PNPM="corepack pnpm@latest install --ignore-scripts --silent"
BENCH_INSTALL_PACQUET="pacquet install"
BENCH_INSTALL_VLT="vlt install --view=silent"
# vlt uses its own config (not .npmrc). When vlt registry credentials are
# available, configure vlt to use the vlt registry via --registry flag and
# VLT_REGISTRY / VLT_TOKEN env vars.
if [ -n "${VLT_REGISTRY_URL:-}" ] && [ -n "${VLT_REGISTRY_AUTH_TOKEN:-}" ]; then
export VLT_REGISTRY="$VLT_REGISTRY_URL"
export VLT_TOKEN="$VLT_REGISTRY_AUTH_TOKEN"
BENCH_INSTALL_VLT="vlt install --registry=$VLT_REGISTRY_URL --view=silent"
else
BENCH_INSTALL_VLT="vlt install --view=silent"
fi
BENCH_INSTALL_BUN="bun install --ignore-scripts --silent"
BENCH_INSTALL_DENO="deno install --quiet"
BENCH_INSTALL_AUBE="aube install --silent"
Expand Down