Skip to content

fix: remove stale @ts-ignore for localIdeographFontFamily across all map modules #2587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
subodhbhyri wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: remove stale @ts-ignore for localIdeographFontFamily across all map modules #2587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/main/src/mapbox-legacy/mapbox/mapbox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,7 +501,7 @@ export default class Mapbox {
diff: styleDiffing
};
if ('localIdeographFontFamily' in nextProps) {
// @ts-ignore Mapbox specific prop
// mapbox-gl v1 ships no bundled types but supports this option at runtime; TS 4.9+ in-narrowing makes this type-safe
options.localIdeographFontFamily = nextProps.localIdeographFontFamily;
}
this._map.setStyle(normalizeStyle(mapStyle), options);
Expand Down
2 changes: 1 addition & 1 deletion modules/react-mapbox/src/mapbox/mapbox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,7 +498,7 @@ export default class Mapbox {
diff: styleDiffing
};
if ('localIdeographFontFamily' in nextProps) {
// @ts-ignore Mapbox specific prop
// localIdeographFontFamily is a MapOptions field in mapbox-gl v3; TS 4.9+ in-narrowing makes this type-safe
options.localIdeographFontFamily = nextProps.localIdeographFontFamily;
}
this._map.setStyle(normalizeStyle(mapStyle), options);
Expand Down
2 changes: 1 addition & 1 deletion modules/react-maplibre/src/maplibre/maplibre.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,7 @@ export default class Maplibre {
diff: styleDiffing
};
if ('localIdeographFontFamily' in nextProps) {
// @ts-ignore Mapbox specific prop
// localIdeographFontFamily is a MapLibre StyleOptions field; TS 4.9+ in-narrowing makes this type-safe
options.localIdeographFontFamily = nextProps.localIdeographFontFamily;
}
this._map.setStyle(normalizeStyle(mapStyle), options);
Expand Down