Add Lyrics support but not happy for merge#119
Add Lyrics support but not happy for merge#119neoedmund wants to merge 2 commits intovideolan:masterfrom
Conversation
|
Thanks a lot for your pull request! It would be an interesting addition to the app. Unfortunately, this repository is only a mirror and all request should be done on https://code.videolan.org/videolan/vlc-android/-/merge_requests Could you please open it there? If you need any help to migrate this request to our Gitlab, please let me know. |
|
hello can i ask for a feature to minimize bugs in the app option to change language because the app have issues with languages that turn it right to left please consider this |
|
An issue i am encountering is that if I want to switch sides of "Brightness" and "Volume" in VLC android,I am not able to do. It would be an small but impactful addition... |
|
I’m really interested in adding lyrics support to VLC Android. My approach will be to clean up the patch, handle .lrc files properly, and fix issues like play position and display on pause. I’ll open a PR on GitLab shortly. |
You should open a MR on our gitlab instead. This repo is only a mirror. |
I made the just work patch for adding lyrics function for audio.
But I'm sorry about the "dirty" code, so It will not be merged to the original repo. But anyone need the lyrics is welcome to download the apk from the release section of this repo.
Thanks