fix(ci): require master for delete-release workflow#39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Delete Releaseworkflow to run only frommastergithub.tokengithub-releasebinary from an older branchWhy
delete-release.ymlbootstrapsgithub-releasefrom the currentverzly/toolchaincheckout:That means the workflow does not use a published release binary. It runs whatever source code exists on the selected ref.
If the workflow is dispatched from an outdated or partially merged branch, rollback can execute old tag-repair logic even when
masteralready contains the correct fixes. In practice this can leave inconsistent state behind, especially for partial delete cases where:vX.Y.Zis already missing<distribution>-vX.Y.Zmay still exist in the monorepovX.Y,vX,latest, andnextstill need to be recalculated or removedThis change turns that into a hard precondition so release deletion always runs from the canonical source of truth.
Changes
delete-release.ymlmasterValidation
git diff --check