Skip to content

fix(ci): require master for delete-release workflow#39

Merged
rozsazoltan merged 1 commit into
masterfrom
fix
Jun 16, 2026
Merged

fix(ci): require master for delete-release workflow#39
rozsazoltan merged 1 commit into
masterfrom
fix

Conversation

@rozsazoltan

Copy link
Copy Markdown
Contributor

Summary

  • require the Delete Release workflow to run only from master
  • make the workflow checkout explicit with github.token
  • prevent rollback runs from compiling and executing a stale github-release binary from an older branch

Why

delete-release.yml bootstraps github-release from the current verzly/toolchain checkout:

cargo build --release -p github-release

That means the workflow does not use a published release binary. It runs whatever source code exists on the selected ref.

If the workflow is dispatched from an outdated or partially merged branch, rollback can execute old tag-repair logic even when master already contains the correct fixes. In practice this can leave inconsistent state behind, especially for partial delete cases where:

  • vX.Y.Z is already missing
  • <distribution>-vX.Y.Z may still exist in the monorepo
  • vX.Y, vX, latest, and next still need to be recalculated or removed

This change turns that into a hard precondition so release deletion always runs from the canonical source of truth.

Changes

  • add a source-ref validation step to delete-release.yml
  • fail early when the workflow is not started from master
  • keep the bootstrap path unchanged, but guarantee it compiles from the correct branch

Validation

  • git diff --check

@rozsazoltan rozsazoltan merged commit 60a0fa1 into master Jun 16, 2026
@rozsazoltan rozsazoltan deleted the fix branch June 16, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant