workflow: rework sandboxing of sys.modules#144
Open
msullivan wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The handling of sys.modules for sandboxes was not concurrency safe, which is a problem because every queue request is handled in a separate thread. Instead of trying to do these big manipulations of sys.modules, follow what Temporal does and install a proxying sys.modules shim that allows each context to have its own set of imported modules. This allows workflows to be run in fresh module environments where we can ensure that everything is intercepted by the sandbox and that won't have any interference with or from steps, while allowing steps to run without needing to interact with proxy modules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The handling of sys.modules for sandboxes was not concurrency safe,
which is a problem because every queue request is handled in a
separate thread.
Instead of trying to do these big manipulations of sys.modules, follow
what Temporal does and install a proxying sys.modules shim that allows
each context to have its own set of imported modules.
This allows workflows to be run in fresh module environments where we
can ensure that everything is intercepted by the sandbox and that
won't have any interference with or from steps, while allowing steps
to run without needing to interact with proxy modules.