workflows: switch to raising EntityConflictError in some places in local world#141
Merged
Conversation
…cal world There were some cases that raised RuntimeError, but they are reachable due to legitimate races I think (though other fixes I've made should make them less likely?), so we should raise EntityConflictError. This should match what JS does.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
fantix
approved these changes
Jun 24, 2026
fantix
left a comment
fantix
left a comment
Member
There was a problem hiding this comment.
Ah yes, good call! EntityConflictError was added in a later stage so these were missed out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were some cases that raised RuntimeError, but they are reachable
due to legitimate races I think (though other fixes I've made should
make them less likely?), so we should raise EntityConflictError.
This should match what JS does.