workflows: put a Lock around local events_create#140
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
fantix
approved these changes
Jun 24, 2026
fantix
left a comment
fantix
left a comment
Member
There was a problem hiding this comment.
This is fine; we should probably also fix the vqs-py handler not to use to_thread() arbitrarily upon async functions.
There are some read-modify-writes in it, so slap a per-run lock around it to protect those. The JS library does more fine-grained locking here but I don't think the extra complication of that would really help much.
msullivan
force-pushed
the
local-world-lock
branch
from
fad8b4e to
9349602
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some read-modify-writes in it, so slap a per-run lock around
it to protect those.
The JS library does more fine-grained locking here but I don't think
the extra complication of that would really help much.