Skip to content

fix(eve): accept scoped package names in eval target check#168

Open
BlackishGreen33 wants to merge 4 commits into
vercel:mainfrom
BlackishGreen33:bg/fix-scoped-eval-target-112
Open

fix(eve): accept scoped package names in eval target check#168
BlackishGreen33 wants to merge 4 commits into
vercel:mainfrom
BlackishGreen33:bg/fix-scoped-eval-target-112

Conversation

@BlackishGreen33

@BlackishGreen33 BlackishGreen33 commented Jun 21, 2026

Copy link
Copy Markdown

What

eve eval now uses the same package-name normalization as agent discovery when it checks the target identity.

For a scoped package like @acme/agent, eval expects the runtime agent id agent instead of the full package name @acme/agent.

This fixes valid scoped-package projects failing before evals start:

Expected eval target "@acme/agent" at http://127.0.0.1:4275, but "agent" is responding there.

Closes #112.

How

readExpectedAgentName() now strips the npm scope from package.json.name before passing the expected name into the eval target handshake.

The existing target mismatch guard stays in place. If the current app is @acme/agent and the server responds as other-agent, eve eval still fails the handshake.

Tests / changeset

  • Added a scenario regression for a project named @acme/agent, asserting that eve eval --url ... checks for agent.
  • Kept the existing unit coverage for target identity mismatch behavior.
  • Added a patch changeset for eve.

Verification

  • fnm exec --using v24.15.0 pnpm --filter eve exec vitest run --config vitest.scenario.config.ts test/scenarios/eval-command-environment.scenario.test.ts
  • fnm exec --using v24.15.0 pnpm --filter eve exec vitest run --config vitest.unit.config.ts src/evals/target.test.ts
  • fnm exec --using v24.15.0 pnpm --filter eve run typecheck
  • fnm exec --using v24.15.0 pnpm exec oxfmt --check packages/eve/src/evals/cli/eval.ts packages/eve/test/scenarios/eval-command-environment.scenario.test.ts .changeset/scoped-eval-target.md
  • git diff --check

Signed-off-by: 墨綠BG <s5460703@gmail.com>
Copilot AI review requested due to automatic review settings June 21, 2026 20:11
@vercel

vercel Bot commented Jun 21, 2026

Copy link
Copy Markdown

@BlackishGreen33 is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

ikindacodes added a commit to ikindacodes/ship-eve that referenced this pull request Jun 21, 2026
Track vercel/eve#168 for restoring scoped support-bot package naming once eval accepts monorepo targets.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

eve eval rejects scoped package targets: "Expected @scope/name … but name is responding"

2 participants