fix(eve): accept scoped package names in eval target check#168
Open
BlackishGreen33 wants to merge 4 commits into
Open
fix(eve): accept scoped package names in eval target check#168BlackishGreen33 wants to merge 4 commits into
BlackishGreen33 wants to merge 4 commits into
Conversation
Signed-off-by: 墨綠BG <s5460703@gmail.com>
|
@BlackishGreen33 is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
ikindacodes
added a commit
to ikindacodes/ship-eve
that referenced
this pull request
Jun 21, 2026
Track vercel/eve#168 for restoring scoped support-bot package naming once eval accepts monorepo targets. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
eve evalnow uses the same package-name normalization as agent discovery when it checks the target identity.For a scoped package like
@acme/agent, eval expects the runtime agent idagentinstead of the full package name@acme/agent.This fixes valid scoped-package projects failing before evals start:
Closes #112.
How
readExpectedAgentName()now strips the npm scope frompackage.json.namebefore passing the expected name into the eval target handshake.The existing target mismatch guard stays in place. If the current app is
@acme/agentand the server responds asother-agent,eve evalstill fails the handshake.Tests / changeset
@acme/agent, asserting thateve eval --url ...checks foragent.patchchangeset foreve.Verification
fnm exec --using v24.15.0 pnpm --filter eve exec vitest run --config vitest.scenario.config.ts test/scenarios/eval-command-environment.scenario.test.tsfnm exec --using v24.15.0 pnpm --filter eve exec vitest run --config vitest.unit.config.ts src/evals/target.test.tsfnm exec --using v24.15.0 pnpm --filter eve run typecheckfnm exec --using v24.15.0 pnpm exec oxfmt --check packages/eve/src/evals/cli/eval.ts packages/eve/test/scenarios/eval-command-environment.scenario.test.ts .changeset/scoped-eval-target.mdgit diff --check