[chat] fix Slack streaming team ID for interactive payloads#330
Open
mdnanocom wants to merge 1 commit intovercel:mainfrom
Open
[chat] fix Slack streaming team ID for interactive payloads#330mdnanocom wants to merge 1 commit intovercel:mainfrom
mdnanocom wants to merge 1 commit intovercel:mainfrom
Conversation
Contributor
|
@mdnanocom is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
8c25a76 to
0549c4f
Compare
8aecb22 to
912b49a
Compare
912b49a to
103a99c
Compare
Contributor
Author
|
@bensabic hello! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Slack structured streaming from
block_actionshandlersCalling
thread.post(stream)from anonActionhandler fails becauserecipientTeamIdis derived as an object instead of a workspace ID string.Cause
thread.handleStreamused:raw.teamis"T123"→ works.block_actionspayloads:raw.teamis{ id: "T123", domain: "..." }→ returned an object, Slack rejects the stream.Fix
Extract the team ID with a helper that accepts every shape Slack sends:
raw.team_idraw.team(string)raw.team.id(block_actions)raw.user.team_id(fallback)Only
packages/chat/src/thread.tschanges. No public API change. Only the Slack adapter readsrecipientTeamId.Tests
block_actionsstructured‑chunk case.buttonPrompt+buttonActionfixtures assertchatStreamreceivesrecipient_team_idand atask_updatechunk.