feat: zero new --json envelope with order-independent args#73
Conversation
|
@gke0op is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| ZBuf entry_path; | ||
| zbuf_init(&entry_path); | ||
| zbuf_append(&entry_path, command->input); | ||
| zbuf_append(&entry_path, "/src/main.0"); |
There was a problem hiding this comment.
The JSON entry field in zero new --json is hardcoded to src/main.0 for all project kinds, but the lib template uses src/lib.0 as its entry point.
| zbuf_append(&buf, "\"zero check "); | ||
| zbuf_append(&buf, command->input); | ||
| zbuf_append(&buf, "\", \"zero test "); | ||
| zbuf_append(&buf, command->input); | ||
| zbuf_append(&buf, "\""); | ||
| if (strcmp(command->kind, "lib") != 0) { | ||
| zbuf_append(&buf, ", \"zero run "); | ||
| zbuf_append(&buf, command->input); | ||
| zbuf_append(&buf, "\""); |
There was a problem hiding this comment.
The nextSteps JSON array values embed command->input (project name) directly into manually-constructed quoted strings without JSON escaping, producing malformed JSON when the project name contains ", \, or control characters.
Rebase complete ✅Rebased onto latest origin/main (v0.1.2, post borrow-provenance + HTTP client merge). All conflicts resolved. Each branch now has a clean linear history on top of current main. |
|
Rebased onto latest origin/main (v0.1.2). All conflicts resolved. Clean linear history. |
Adds --json flag to zero new, outputting structured JSON with: - schemaVersion, ok, kind, name, path - manifest, entry paths - nextSteps (lib omits 'zero run') Arg parser rewritten to be order-independent: - --json can appear before or after positional args - --json can appear between kind and name Plain-text output unchanged. Tested: - zero new --json cli mycli → correct JSON envelope - zero new lib mylib --json → lib omits run from nextSteps - zero new --json package test-pkg → package includes run - Plain text output unchanged - All 11 CLI tests pass Closes vercel-labs#22
1 participant
Summary
Adds
--jsonflag tozero new, outputting structured JSON with:schemaVersion,ok,kind,name,pathmanifest,entrypathsnextSteps(lib omitszero run)Arg parser rewritten to be order-independent:
--jsoncan appear before or after positional args--jsoncan appear between kind and namePlain-text output unchanged.
Testing
zero new --json cli mycli→ correct JSON envelopezero new lib mylib --json→ lib omits run from nextStepszero new --json package test-pkg→ package includes runCloses #22